Footnotes: Remove extra callback when parsing content #66370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -13 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Oct 23, 2024
mcsf
approved these changes
Oct 23, 2024
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: tyxla <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: mcsf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the extra callback for updating footnotes when parsing content, which seems to be unnecessary since #52577.
Why?
React Compiler seems to dislike instances where a cached function depends on another cached function. See #66361 that experiments with React Compiler and generates errors in the post editor (see screenshot below).
How?
I found this behavior unexpected and would like to dig further into it. But in the meantime, it does look like the inner callback is unnecessary, (since #52577) so I'm removing it, in favor of the outer ones. Removing the inner callbacks and moving the dependency to them fixes the issue.
Testing Instructions
This shouldn't have any impact on behavior, but you can test it with a post with many footnotes and ensure they continue to work well.
Performance test results should also not be impacted negatively.
You can also test this with React Compiler:
npm installnpm run devTesting Instructions for Keyboard
Same
Screenshots or screencast