Cover: Try allowing the auto overlay color when changing images to be more permissive #65077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -102 B (-0.01%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
The deprecation is in place for existing blocks prior to auto overlay color to not re-color when updating an image as that's a change in behavior that may be unexpected. All blocks prior to auto-color were user-specified which is why it's a deprecation. Relevant discussion here #54054 (comment) and here #54054 (review).
I think what we need is just to set |
Excellent, thanks for the extra context and the suggestion @ajlende! I'll close this out, I've opened a separate PR over in #65105 that implements this idea 👍 — let's see if we can land that approach instead. |
johnbillion
deleted the
update/cover-auto-overlay-color-to-be-more-permissive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #64702
This PR seeks to make the Cover block's behaviour where it adds an auto overlay color more permissive than it is currently. That is, as described in #64702, currently the auto color only works up until you first save a post. One you've saved and reloaded, the deprecation in the Cover block fires, and sets
isUserOverlayColortotrue, preventing the auto overlay color from happening again.To recap: the auto overlay color feature is that when you upload or add an image to the Cover block, the overlay color is selected based on average colors within the image.
Why?
As described in #64702, it can be unexpected for the auto color behaviour to suddenly stop working. The boundary between reloading can also be a bit unexpected. Further, this deprecation was applying more frequently than expected, and there could be alternate ways to approach the feature. For now, this PR proposes removing the deprecation altogether, as its only purpose was to switch
isUserOverlayColortotrue. This might also resolve an issue described in #64480 (comment).However, I might very well be missing context as to why this deprecation was added originally, so very happy for feedback or to close out this PR if there is a better way to address this problem.
How?
savestate, and its only responsibility was to add theisUserOverlayColorattribute and set it totrue.Testing Instructions
Follow the reproduction steps in #64702. Basically:
Testing Instructions for Keyboard
Screenshots or screencast
This screengrab demos the auto color overlay holding up beyond reloading the post editor. It only sticks once a user sets an overlay color deliberatly:
cover-block.mp4