DataViews: consider layout url parameter when loading a default/custom view #64306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Bug
|
Size Change: +24 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Aug 7, 2024
| @@ -41,7 +41,7 @@ export default function DataViewItem( { | |||
| } | |||
| const linkInfo = useLink( { | |||
| postType, | |||
| layout, | |||
| layout: type, | |||
There was a problem hiding this comment.
What happens if we drop this argument entirely. I think it's not needed right?
There was a problem hiding this comment.
It is. Otherwise, the dataview & the site editor's layout get out of sync (in the video below, the default trash view & the custom ThemeBuster view use table, but the site editor's layout is not updated accordingly) :
Gravacao.do.ecra.2024-08-07.as.13.55.54.mov
There was a problem hiding this comment.
yes, the router assumes the default value is "list" if the layout is not present.
youknowriad
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #63889
What?
In the Pages page, consider the
layoutparameter when loading a view.Why?
URLs represent (partially) the state of DataViews, and it needs to load properly.
How?
Testing Instructions
Visit the Pages page in Site Editor and verify a few flows: