Global Styles: Fix UI appearing on blocks that don't support text alignment #62376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +3 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aaronrobertshaw
approved these changes
Jun 7, 2024
|
Thanks for the review! |
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
…gnment (#62376) Co-authored-by: t-hamano <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: juanfra <[email protected]> Co-authored-by: richtabor <[email protected]>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
…gnment (#62376) Co-authored-by: t-hamano <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: juanfra <[email protected]> Co-authored-by: richtabor <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…gnment (WordPress#62376) Co-authored-by: t-hamano <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: juanfra <[email protected]> Co-authored-by: richtabor <[email protected]>
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62369
What?
This PR fixes an issue where the Text Alinment UI would unintentionally appear even though the block did not support
typography.textAlign.Why?
#61182 changed
textAligntotruein the defaulttheme.json, so this support is enabled at a global level, but we still needed to check if a block actually supported it.How?
Added
textAlignto theuseSettingsForBlockElementhook.Testing Instructions
Visit the following screens in the default state. The Text Alignment UI should not be visible on any of the screens.
After that, add
textAlignsupport to Media & Text.The Text Alignment UI should only be visible in the following places: