Try: Wrap date-time stamp well for publish status #61492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +3.62 kB (+0.21%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
May 8, 2024
jameskoster
reviewed
May 8, 2024
| @@ -16,6 +16,11 @@ | |||
| height: auto; | |||
| min-height: $button-size-compact; | |||
|
|
|||
| // This needs specificity. | |||
| &.components-button { | |||
| text-wrap: pretty; | |||
There was a problem hiding this comment.
I wonder if we should apply this to all buttons in .editor-post-panel__row? That way we'd also capture templates with long labels.
|
Moved it, let me know if this is a better place for it. |
|
Seems fine. But now I'm wondering if we should apply this at the component level :) Ideally wrapping in button labels should be kept to a minimum, but when it does occur shouldn't it always be cc @WordPress/gutenberg-components. |
|
@jasmussen as you suggested I have updated my PR. Please check it once. |
I'd prefer to keep this outside of the components territory, as it could break (or inadvertently change) existing buttons. Maybe we could reconsider if the browser support improves. Also, some folks might prefer |
|
Thanks for the work, @itzmekhokan and the feedback Tyxla! Catching up: @jameskoster can you take a glance and see if we should land this one, or #61703? |
|
The appearance of these buttons is very inconsistent: 
Imo they should all respect the same rules, and likely be fixed in a single PR. I have a small preference for truncating to one line; the full value can be viewed by clicking the button, or in the case of the date button by inokving the tooltip on hover/focus. Visually it looks neater: 
If truncating to a single line is too aggressive, then perhaps to 3 or 4 lines so we can avoid this: 
|
This was referenced May 22, 2024
Open
|
Closing in favor of #61954. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The date-stamp in the summary panel can wrap poorly when it's long, usually putting the timezone on its own line out of context with the time itself:
This PR adds text-wrap: pretty; to address this so the timezone is more likely to be in context of the timestamp:
Testing Instructions
Write a post, change its status to scheduled, and observe the date-stamp in the summary panel. It should wrap well.