Try: Improve date-wrapping in prepublish flow #61490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +47 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
May 8, 2024
|
I looked at that, but this code is a bit of a mess and really deserves moving to some of the new componentry, which is a larger undertaking. If I just apply the line-height in the same space as the text-wrap property, the line-height becomes non uniform:
For now, I think I'll land this as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If you schedule a post, the pre-publishing flow poorly wraps the date timestamp. As shown in this picture, the status is vertically centered with the timestamp itself wrapping on two lines, in an unbalanced fashion.
This PR adds better text wrapping and top alignment, so it balances better:
Testing Instructions
Write a post, schedule it, start the pre-publish flow. The date dropdown should be top-aligned and wrap the long date-stamp well.