Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactivity API: Added comments for directive parsing #61456

Closed
wants to merge 5 commits into from
Closed

Interactivity API: Added comments for directive parsing #61456

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
06c644a
Added comments for directive parsing
amitraj2203 May 7, 2024
cdaa80a
Changed the variables names
amitraj2203 May 7, 2024
829c7a0
Removed few comments
amitraj2203 May 7, 2024
86fa61c
Merge branch 'trunk' of github.com:amitraj2203/gutenberg into fix/iss…
amitraj2203 May 14, 2024
2d68cb8
Removed few comments and changed variable name
amitraj2203 May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/interactivity/src/vdom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,11 @@ export function toVdom( root ) {
}

if ( directives.length ) {
// Reduce the directives array to build the __directives object.
props.__directives = directives.reduce(
// The reducer function accumulates the __directives object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// The reducer function accumulates the __directives object.

Same here.

( obj, [ name, ns, value ] ) => {
// Check if the directive name matches the expected format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Check if the directive name matches the expected format.

Same here.

const directiveMatch = directiveParser.exec( name );
if ( directiveMatch === null ) {
if (
Expand All @@ -131,9 +134,11 @@ export function toVdom( root ) {
}
return obj;
}
const prefix = directiveMatch[ 1 ] || '';
const suffix = directiveMatch[ 2 ] || 'default';
// Splitting the directive name into prefix and suffix.
const prefix = directiveMatch[ 1 ] || ''; // The prefix part of the directive name.
const suffix = directiveMatch[ 2 ] || 'default'; // The suffix part of the directive name, defaulting to 'default' if not present.

// Creating or updating the array for the specific prefix in the directives object.
obj[ prefix ] = obj[ prefix ] || [];
obj[ prefix ].push( {
namespace: ns ?? currentNamespace(),
Expand Down
Loading