Block card: Fix typographic widow. #61438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -34 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
May 7, 2024
There was a problem hiding this comment.
If we need to apply text-wrap: pretty to this part, doesn't that mean we need to follow Gutenberg's typography system, which means replacing it with a Text component?
<Text className="block-editor-block-card__description">
{ description }
</Text>For example, the site editor template description already uses this component.
However, this component has a zero margin applied, so it will override the 4px ($grid-unit-05) top margin.
To solve this, how about using padding instead of margin, or changing the card content itself to a stacked layout and applying gap?
|
While we're at it we should fix this 🙈 
Seems to be caused by Edit: Nevermind, this seems to be fixed by #61137. |
|
Good feedback. Uses Text and VStack now, and looks good:
|
|
Looks like I need to fix some tests. I'll do that when I get a moment! Thanks for the advice and reviews. |
|
Sorry, we should have left the class name. It should now pass the E2E test. |
|
Looks like there's a new failing test. I can look again at a different time, but have to move on to other things. If any of you want to, feel free to push changes, otherwise I'll get back to it when I can! |
|
@jasmussen I've fixed the code so that it passes the e2e tests, and I updated this branch with the latest trunk just to be sure. Once GitHub Actions passes, I should be able to merge this PR. |
|
Want to merge or should I press the button? Thanks again. |
bph
added
[Type] Bug
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
* Block card: Fix typographic widow. * Use Text and VStack. * Restore classname. * Try to fix e2e test --------- Co-authored-by: Tetsuaki Hamano <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* Block card: Fix typographic widow. * Use Text and VStack. * Restore classname. * Try to fix e2e test --------- Co-authored-by: Tetsuaki Hamano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix a typographic widow — a terrible typographical term for a word that stands alone on a line — in the block card.
Why?
This balances the text to be harmonious, while working across translations. It is already applied by default to the
Textcomponent.How?
By applying
text-wrap: pretty;.Testing Instructions
Screenshots or screencast
Before:
After: