Create Block: Match specified engines with Gutenberg and Core #61430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Build Tooling
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.74 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 6ef8a0a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8981259018
|
gziolo
approved these changes
May 7, 2024
|
Thanks for the review, @gziolo! |
|
@fabiankaegy, an entry in the changelog is always useful 👍 Do you think the requirements should be lifted to Node 18 (still long term support version) like for all other WP packages? |
|
@gziolo I'm fine with node 20 :) My main comment was that usually updating the minimum required node version constitutes a breaking change update of the package. So In this case this should have meant changing the version of the package to |
Yes, that sounds right. It's also too late for major version upgrade now, but at least we could add the CHANGELOG to the minor version that was impacted. |
|
Opened #62791 to address the issue mentioned by @fabiankaegy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #60962.
PR updates engines specified in the
package.jsonfile to match Gutenberg and WP Core.CI checks should be green.
Why?
The
npm installmight fail when using node version managers due to a version mismatch.Testing Instructions for Keyboard
Same.