Fix zoom out UI scale #61265
Merged
Fix zoom out UI scale #61265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: packages/block-editor/src/components/block-list/content.scss packages/block-editor/src/components/iframe/index.js
|
Size Change: +141 B (+0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
ajlende
changed the base branch from
fix/iframe-code-editor-zoom-out-crash
to
trunk
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
reviewed
May 8, 2024
| @@ -1,7 +1,7 @@ | |||
| .edit-site-code-editor { | |||
| position: relative; | |||
| width: 100%; | |||
| min-height: 100%; | |||
There was a problem hiding this comment.
This keeps the background filllng the screen.
MaggieCabrera
approved these changes
May 8, 2024
ellatrix
reviewed
May 8, 2024
|
|
||
| .block-editor-iframe__html.is-zoomed-out { | ||
| $scale: var(--wp-zoom-out-scale); | ||
| $frame-size: var(--wp-zoom-out-frame-size); |
There was a problem hiding this comment.
Why did you move everything to CSS? We only need --wp-zoom-out-scale?
This is going to be problematic when I try to animate both scroll and scale in JS at the same time with the same function.
There was a problem hiding this comment.
Or I wonder if animating these variables will be the same in terms of performance. But still, I don't get why we make all of these variables if it's not needed.
There was a problem hiding this comment.
We might also want to prefix it with wp-block-editor, not sure
There was a problem hiding this comment.
Or I wonder if animating these variables will be the same in terms of performance. But still, I don't get why we make all of these variables if it's not needed.
It was easier to read. I would expect the styling to be done in CSS. And it seemed like performance wouldn't be worse.
This is going to be problematic when I try to animate both scroll and scale in JS at the same time with the same function.
Why do you need to animate them in JS? Can't the animations be done with CSS?
ellatrix
requested changes
May 8, 2024
ellatrix
reviewed
May 8, 2024
| .block-editor-block-list__block.has-block-overlay::before { | ||
| left: 0; | ||
| right: 0; | ||
| width: auto; |
There was a problem hiding this comment.
Why are we changing these rules?
There was a problem hiding this comment.
It provides exact sizing instead of using the hack that is sometimes wrong.
ellatrix
approved these changes
May 9, 2024
ellatrix
reviewed
May 9, 2024
| // TODO: `marginBottom` doesn't work in Firefox. We need another way | ||
| // to do this. | ||
| documentElement.style.marginBottom = `${ bottomFrameSize }px`; | ||
| if ( iframeWindowInnerHeight > contentHeight * scale ) { |
There was a problem hiding this comment.
Let's see in a follow-up if this is still needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes some UI issues in zoom-out mode such as bottom padding in Firefox and scale of the border in zoom out mode.
Why?
Bug fix
How?
Moves calculations into CSS where we can take advantage of the layout engine to simplify some calculations.
Also moved the iframe css to the iframe component instead of block-list.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast