Align list and table layout visuals #61157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jameskoster
commented
Apr 26, 2024
| @@ -418,6 +406,7 @@ | |||
| &:hover, | |||
| &:focus-within { | |||
| color: var(--wp-admin-theme-color); | |||
| background-color: #f8f8f8; | |||
There was a problem hiding this comment.
We need to add a var for this at some point.
|
Size Change: -73 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
When hovering items, the color of the text stays black in "table" but is "blue" in "list". Is this something to be aligned too? |
|
I think it's okay for those to be different because in table layout the title is a separate element (link) whereas in list layout the entire row is the button. |
|
ok WFM |
youknowriad
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Align the visual treatment of states across list and table layouts in data views.
Why?
In both layouts items/rows can be hovered/selected, yet those states have different visual treatments which adds to the cognitive load. There are other subtle differences such as full-width vs indented strokes, and the inclusion of a stroke above the first item. These details have also been aligned.
The active/selected state in List layout was also clashing somewhat with the active menu item in the sidebar.
How?
Update list layout to more closely resemble table layout.
Testing Instructions
Before
After