Try: Introduce 'getEntityConfig' resolver #61101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: +341 B (+0.02%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
try/get-entity-config-resolver
branch
from
a5b1179 to
a6d68c1
Compare
|
@jsnajdr, @youknowriad, this is still in progress, but I would appreciate early feedback when you have time. I might have an alternative solution for the last to-do item - |
|
Would you mind expanding a bit on the reasoning to clarify the purpose of this PR for everyone. On the change itself, it seems reasonable at first sight. |
|
Sorry about that. I've updated the Why section of the PR description. |
Mamaduka
force-pushed
the
try/get-entity-config-resolver
branch
from
a6d68c1 to
e526e92
Compare
3 tasks
|
Closing in favor of #65871. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR introduces a resolver for
getEntityConfigand replacesgetOrLoadEntitiesConfigwith it.Why?
Currently, if two or more components call
getEntityRecodsimultaneously for an entity with the config loaded from the server, theloadermethod can make duplicate requests. The resolvers keep track of HTTP requests in progress and avoid hitting the same endpoint multiple times.Based on the usages of
getOrLoadEntitiesConfig, it seems better to add a resolver for thegetEntityConfigselector.The idea is derived from explorations in #61088.
Todos
getOrLoadEntitiesConfigleftovers.registerSyncConfigs. Maybe we can call it inside the selector?getEntityConfig( 'postType', 'page' )whilegetEntityConfig( 'postType', 'post' )is resolving and shouldn't trigger another request. ThecanUserresolve has a similar logic. However, I might need to updatehasStartedResolutionto support "wildcard" args.How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast