ListView: reduce subs per item #58542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +78 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ellatrix
added
the
[Feature] List View
Agreed. It became easy to include one more piece of information in that hook. We should probably refactor its usage in the code base and deprecate it. |
ellatrix
force-pushed
the
try/list-view-reduce-subs
branch
from
cd92ea9 to
dd525ea
Compare
|
Looks like this PR is throwing an error after #58533 landed, which added a check to return early if a |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Are we planning to track typing performance metrics with List View open? I think it would be an excellent way to validate performance improvement. |
|
Not against that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A couple of things:
getBlockselector, it's only needed for the clientId.useBlockDisplayInformation. This is a terrible way to get information, because you cannot specify the information you need. We should use store selectors instead. If the store selectors are awkward, we should create better store selectors. In this case we're only using it to get the block title and whether it's a synced block.useBlockLock, we don't need all the info there, and we create a separate subscription. Let's create better selectors if it's too verbose.Why?
We're currently retrieving unnecessary information from the store. Also every block editor store store subscription slows down load but especially typing (in this case typing with the list view open).
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast