-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close the pattern category when the right sidebar is open in zoom-out mode #56892
Merged
aaronrobertshaw
merged 1 commit into
try/zoomed-out-mode-experiments
from
fix/close-pattern-category-on-sidebar-open
Dec 8, 2023
Merged
Close the pattern category when the right sidebar is open in zoom-out mode #56892
aaronrobertshaw
merged 1 commit into
try/zoomed-out-mode-experiments
from
fix/close-pattern-category-on-sidebar-open
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3aee529
to
fa8c08a
Compare
Size Change: +63 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised for me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Inserter
The main way to insert blocks using the + button in the editing interface
[Feature] Patterns
A collection of blocks that can be synced (previously reusable blocks) or unsynced
[Type] Experimental
Experimental feature or API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #56806.
Close the pattern category when the right sidebar is open in zoom-out mode.
Why?
The pattern category panel is inlined when entering the zoom-out mode so the canvas has limited space for the right sidebar to be opened.
How?
Add some hacky imperative methods to the library ref.
Testing Instructions
Screenshots or screencast
Kapture.2023-12-08.at.16.51.41.mp4