-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent block switcher menu while in zoomed out mode #56888
Merged
talldan
merged 1 commit into
try/zoomed-out-mode-experiments
from
try/no-block-switcher-menu-in-zoom-mode
Dec 8, 2023
Merged
Prevent block switcher menu while in zoomed out mode #56888
talldan
merged 1 commit into
try/zoomed-out-mode-experiments
from
try/no-block-switcher-menu-in-zoom-mode
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +18 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Dec 8, 2023
Flaky tests detected in 8f8f3da. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7136675154
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
[Type] Experimental
Experimental feature or API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Prevents the block switcher menu while operating in zoomd out mode.
Why?
After switching to the contextual toolbar menu for zoomed out mode, there's a lot we don't need at that point and things like transforms don't make a lot of sense for zoomed out mode.
How?
Checks if the editor is in zoomed out mode and if so renders a basic icon rather than a dropdown menu for the block switcher.
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-12-08.at.2.30.09.pm.mp4
Screen.Recording.2023-12-08.at.2.28.52.pm.mp4