DataViews: add control to reset all filters at once #55955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Feature
oandregal
requested review from
ntsekouras,
youknowriad,
jorgefilipecosta and
jameskoster
|
Size Change: +160 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ec9547f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6796878388
|
oandregal
force-pushed
the
add/reset-all-filters
branch
from
3df9178 to
f7f6937
Compare
ntsekouras
reviewed
Nov 8, 2023
ntsekouras
reviewed
Nov 8, 2023
ntsekouras
reviewed
Nov 8, 2023
ntsekouras
reviewed
Nov 8, 2023
|
I also want to document some potential states. The "reset filters" button is only shown if there is at least one filter:
|
26 tasks
oandregal
added
[Type] Experimental
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
Adds a new control
ResetFiltersto reset all filters at once.Why?
As per the designs:
Testing Instructions
Gravacao.do.ecra.2023-11-08.as.11.25.53.mov