Details: fix multiselect in Chrome #55888
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
Size Change: -2 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
The initial details block was very different from what we have today. The style settings that where once proposed were removed. |
|
Flaky tests detected in 422b301. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6769143990
|
|
With #53282, this block now supports block spacing. So wrapping the content in a div will make a big difference in layout. In other words, in this PR, the block spacing settings are only applied to elements within the content, so no space is applied between the summary element and the first element of the content. Editor (This PR)
Editor (Trunk)
Frontend
I don't have a strong opinion on whether space should also be applied between the summary element and the content, but I think at least the markup on the editor side and the front end side should match. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #55671.
Unfortunately this seems to be a bug in Chrome. In Safari and Firefox it's working correctly. Here's a simple reproducible case: https://codepen.io/iseulde/pen/poGRjYK
A simple workaround is to wrap all the details content in a div.
Tbh, I'm not sure why we didn't save the content in a div from the start, it would add a lot more styling options on the front-end as well. Right now you can't pad and colour all contents for example. Should we add the div in the save function as well?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast