Puppeteer tests: Try to fix failing tests related to notices in core #54452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
the
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.52 MB ℹ️ View Unchanged
|
ramonjd
approved these changes
Sep 14, 2023
|
Is there a timeline for merging this into core tests? I don't know the process for this, but it would be nice to get the core e2e tests passing again. |
Oh, good question! I didn't realise that the core tests use this package, but that makes sense now. I imagine it'll happen when the next JS packages update happens? Might be worth double-checking with the editor tech leads for 6.4. Just pinging @mikachan and @tellthemachines in case I've got it wrong there. |
|
Yup this change should go in with the package updates in WordPress/wordpress-develop#5262. |
mikachan
added
the
Backport to Gutenberg RC
|
Just to double check - should this PR be backported to the 16.7 RC, or do these changes need to be manually added to WordPress/wordpress-develop#5262? |
|
@mikachan no action needed here; according to the milestone and time of merge this PR should already be in 16.7 RC 🙂 |
tellthemachines
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Try to fix failing Puppeteer tests.
Why?
In core, recent commits update how notices are displayed. It looks like these existing tests might be dependent on the order in which some CSS classes are output. I notice that in core, previously the order was "updated notice is-dismissible", but the order is now "notice is-dismissible updated".
For these Gutenberg tests, the order is not significant, and I think we might be able to use a single class of "notice" in this Xpath query... at least that's what I'm trying out here!
Notices in WP 6.3.1
Notices in 6.4 alpha
How?
Try making the Xpath query a little less specific to see if that pleases the tests.
Testing Instructions
See if puppeteer tests pass
Testing Instructions for Keyboard
Screenshots or screencast