Extract WordPress specific styles from the BlockTools component #54356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
draganescu,
talldan,
noisysocks,
tellthemachines,
adamziel,
kevin940726 and
ellatrix
as code owners
|
Size Change: +768 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Sep 11, 2023
|
I agree the triplication is unfortunate, but I think it's better than bundling these styles like we had. It's like some duplication of components is better than a wrong abstraction. |
youknowriad
deleted the
extract/block-tools-wordpress-specific-styles
branch
This was referenced Sep 13, 2023
bph
added
Framework
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
mikachan
added
[Package] Edit Post
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #53874
What?
When using Gutenberg for third-party block editors, there's a lot of small issues. One of them is that we have some CSS styles that are written with the generic block editor package that should be specific to the WordPress implementation of these components.
One of these components is the BlockToolbar, in order to support the fixed position (top toolbar) in all the wordpress editors (post editor, site editor and widgets editor), we have accumulated some CSS that is not meant to be included with all usage of the fixed "BlockToolbar" components or "BlockTools" components.
In this PR, I'm adding a new story to Storybook that tries to implement a TinyMCE like box using the block editor package. This highlighted these issues, so this PR also extract these specific styles to the WordPress specific packages.
Testing Instructions
1- Ensure that the "top toolbar" mode still works as intended in all of the following situations:
2- You can also try running storybook and checking the new "playground box" story to understand why these changes are necessary.