Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove Block Grammar doc and all corresponding internal links. #51106

Merged
merged 2 commits into from
Jun 2, 2023

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented May 30, 2023

Fixes #51067

What?

This PR removes the Block Grammar documentation page and all internal links to this page.

Why?

As noted in #51067, the Block Grammar page is no longer needed in the Block Editor Handbook.

@ndiego ndiego added the [Type] Developer Documentation Documentation for developers label May 30, 2023
@ndiego ndiego requested a review from mcsf May 30, 2023 18:25
@ndiego ndiego self-assigned this May 30, 2023
@ndiego
Copy link
Member Author

ndiego commented May 30, 2023

@mcsf I am guessing I also need to remove the generate-public-grammar.js file, but I am not exactly sure how that file works. Is there anything else that needs to be updated related to the generator file?

@mcsf
Copy link
Contributor

mcsf commented Jun 2, 2023

@mcsf I am guessing I also need to remove the generate-public-grammar.js file, but I am not exactly sure how that file works. Is there anything else that needs to be updated related to the generator file?

@ndiego: nope, you can safely delete it. It was there to be called manually whenever (= never) the grammar would change.

Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the generator script is also removed, LGTM! Thanks for the cleanup

@ndiego
Copy link
Member Author

ndiego commented Jun 2, 2023

Perfect, thanks! I will tackle this today

@ndiego ndiego marked this pull request as ready for review June 2, 2023 18:57
@ndiego ndiego enabled auto-merge (squash) June 2, 2023 18:58
@ndiego ndiego disabled auto-merge June 2, 2023 18:58
@ndiego ndiego enabled auto-merge (squash) June 2, 2023 18:58
@ndiego ndiego merged commit 053413e into WordPress:trunk Jun 2, 2023
@github-actions github-actions bot added this to the Gutenberg 16.0 milestone Jun 2, 2023
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
…ordPress#51106)

* Remove grammar doc and all internal links.
* Remove block grammar generator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing "Block Grammar" documentation page
2 participants