Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update border and focus style of the Input selector in ColorPicker Component #50703

Merged
merged 5 commits into from
May 22, 2023
Merged

Update border and focus style of the Input selector in ColorPicker Component #50703

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
34f1bc3
Add border and focus style to the Input selector in ColorPicker
falgunihdesai May 17, 2023
7589753
Use display: block instead of flex
mcsf May 19, 2023
3cc1469
Update CHANGELOG.md
mcsf May 19, 2023
5a12bde
Merge branch 'trunk' into update/50524-colorspace-focus
mcsf May 19, 2023
aa8b11b
Fix formatting in CHANGELOG.md
mcsf May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/src/color-picker/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const SelectControl = styled( InnerSelectControl )`
margin-left: ${ space( -2 ) };
width: 5em;
${ BackdropUI } {
display: none;
display: flex;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason to prefer flex over block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used flex because other elements like Input box for color value and copy button both uses flex. Otherwise block was also working 😄. Was one of the two failed checks because of flex. Failure of Changelog diff check I understood. But the reason for another failed check is not clear to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see it, but if you saw another failure it may have been a flaky end-to-end test. Everything looks good now, so I'll merge. :)

}
`;

Expand Down