Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Logo: add padding and margin support #43520

Merged
merged 20 commits into from
Sep 7, 2022
Merged

Site Logo: add padding and margin support #43520

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
ad6e045
Update DateTimePicker readme
colorful-tones Oct 5, 2021
4ac86ad
Merge branch 'WordPress:trunk' into trunk
colorful-tones Oct 12, 2021
a8ea897
Merge branch 'WordPress:trunk' into trunk
colorful-tones Oct 14, 2021
ade1023
Merge branch 'WordPress:trunk' into trunk
colorful-tones Oct 15, 2021
9cc6b02
Merge branch 'WordPress:trunk' into trunk
colorful-tones Oct 25, 2021
bb60f63
Merge branch 'WordPress:trunk' into trunk
colorful-tones Oct 27, 2021
fb4add5
Merge branch 'WordPress:trunk' into trunk
colorful-tones Oct 28, 2021
8770819
Merge branch 'WordPress:trunk' into trunk
colorful-tones May 27, 2022
508de20
Merge branch 'WordPress:trunk' into trunk
colorful-tones Jun 27, 2022
015cc6d
Merge branch 'WordPress:trunk' into trunk
colorful-tones Aug 23, 2022
f59e2b8
Add padding/margin support for Site Logo
colorful-tones Aug 23, 2022
2450375
Merge branch 'WordPress:trunk' into trunk
colorful-tones Aug 26, 2022
6e07d09
Merge branch 'trunk' into add/site-logo-margin-padding-support
colorful-tones Aug 26, 2022
367de59
Alpha sort active supports
colorful-tones Aug 26, 2022
8e2a53f
Merge branch 'WordPress:trunk' into trunk
colorful-tones Aug 31, 2022
d440f0e
Merge branch 'WordPress:trunk' into trunk
colorful-tones Sep 1, 2022
db2b795
Merge branch 'trunk' into add/site-logo-margin-padding-support
colorful-tones Sep 1, 2022
17fff8f
Merge branch 'WordPress:trunk' into trunk
colorful-tones Sep 6, 2022
065202e
Merge branch 'trunk' into add/site-logo-margin-padding-support
colorful-tones Sep 6, 2022
8538b29
Add box-sizing for frontend
colorful-tones Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reference-guides/core-blocks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,7 @@ Display a graphic to represent this site. Update the block, and the changes appl

- **Name:** core/site-logo
- **Category:** theme
- **Supports:** align, color (~~background~~, ~~text~~), ~~alignWide~~, ~~html~~
- **Supports:** align, color (~~background~~, ~~text~~), ~~alignWide~~, ~~html~~, spacing (margin, padding)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is minor, but can you alphabetize the active supports followed by the alphabetized excluded supports? So spacing would come after color.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing too minor. 👍 I addressed this and alpha sorted. Thanks!

- **Attributes:** isLink, linkTarget, shouldSyncIcon, width

## Site Tagline
Expand Down
4 changes: 4 additions & 0 deletions packages/block-library/src/site-logo/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@
"__experimentalDuotone": "img, .components-placeholder__illustration, .components-placeholder::before",
"text": false,
"background": false
},
"spacing": {
"margin": true,
"padding": true
}
},
"styles": [
Expand Down