Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text/number inputs of ColorPicker keep draft values while focused #41264

Closed
wants to merge 9 commits into from
+317 −242
Closed

Make text/number inputs of ColorPicker keep draft values while focused #41264

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4046235
Fix undo when changing padding values
youknowriad Apr 21, 2022
95209b4
Finish making `InputControl` et al. more controllable (#40568)
stokesman May 11, 2022
b91a418
Fix `RangeControl` reset from values out-of-range by multiple digits
stokesman May 17, 2022
5150ade
Add changelog entry
stokesman May 17, 2022
b67b3b4
Make hex input of `ColorPicker` keep draft values while focused
stokesman May 24, 2022
699ce90
Support draft values in `InputWithSlider` by adding `useDraft` hook
stokesman May 24, 2022
9d7dbc9
Switch to hook for draft value support in `HexInput`
stokesman May 24, 2022
96b0a2e
Update type of `nextValue` in `InputChangeCallback`
stokesman May 24, 2022
301c3d4
Have `UnitControl` avoid sending `undefined` through `onUnitChange`
stokesman May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Have UnitControl avoid sending undefined through onUnitChange
@stokesman
stokesman committed May 24, 2022
commit 301c3d4e10da08d205efe0fad79fce15ec481d37
2 changes: 1 addition & 1 deletion packages/components/src/unit-control/index.tsx
View file
Original file line number Diff line number Diff line change
@@ -179,7 +179,7 @@ function UnforwardedUnitControl(
const changeProps = { event, data };

// The `onChange` callback already gets called, no need to call it explicitely.
onUnitChange?.( validParsedUnit, changeProps );
onUnitChange?.( validParsedUnit ?? '', changeProps );

setUnit( validParsedUnit );
}