Remove forced focus of InputControl on mousedown
#41118
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update `RangeControl` to play nice with revised `InputControl` * Update `UnitControl` to play nice with revised `InputControl` * Restore controlled mode to `RangeControl` * Add missing ; * Add comment after deleting `onChange` * Update test of `RangeControl` to also test controlled mode * Remove separate onChange call from reset handling in `RangeControl` * Refine RESET logic of `InputControl` reducer * Simplify refined RESET logic of `InputControl` reducer * Restore initial position of `RangeControl` when without value * Differentiate state sync effect hooks by event existence * Add and use type `SecondaryReducer` * Cleanup legacy `event.perist()` * Simplify update from props in reducer Co-authored-by: Lena Morita <[email protected]> * Ensure event is cleared after drag actions * Avoid declaration of potential unused variable * Add more reset unit tests for `RangeControl` * Run `RangeControl` unit test in both controlled/uncontrolled modes * Make “keep invaid values” test async * Prevent interference of value entry in number input * Remove unused `floatClamp` function * Fix reset to `initialPosition` * Fix a couple tests for controlled `RangeControl` * Fix `RangeControl` reset * Ensure `InputControl`’s state syncing works after focus changes * Comment * Ignore NaN values in `useUnimpededRangedNumberEntry` * Refine use of event existence in state syncing effect hooks Co-authored-by: Marco Ciampini <[email protected]> Co-authored-by: Lena Morita <[email protected]>
|
Size Change: -56 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ciampo
reviewed
May 19, 2022
| @@ -41,18 +41,6 @@ describe( 'InputControl', () => { | |||
| } ); | |||
| } ); | |||
|
|
|||
| describe( 'Ensurance of focus for number inputs', () => { | |||
| it( 'should focus its input on mousedown events', () => { | |||
There was a problem hiding this comment.
Maybe a silly question, but — shouldn't we keep this unit test?
Technically the code in this PR is not necessary, given change in #40518 — and therefore I would keep the unit tests as they are, and expect the to still pass.
There was a problem hiding this comment.
The test was added along with the code in #29305. I expected such a test to never fail #29305 (comment) because inputs are focused on mousedown (except Firefox when mousedown is on the spin buttons). Apparently that focus is not synchronous. So without the code this test fails.
There was a problem hiding this comment.
I see, thank you for the context!
I tried using user-event and it seems to fix the issue:
describe( 'Ensurance of focus for number inputs', () => {
it( 'should focus its input on mousedown events', async () => {
const user = userEvent.setup( {
advanceTimers: jest.advanceTimersByTime,
} );
const spy = jest.fn();
render( <InputControl type="number" onFocus={ spy } /> );
const input = getInput();
await user.click( input );
expect( spy ).toHaveBeenCalledTimes( 1 );
} );
} );
stokesman
force-pushed
the
fix/input-field-reset-behavior
branch
from
5150ade to
3ac6020
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes code obviated by #40518. For now this is based on the branch from that PR but once it lands I'll switch this to trunk.
Why?
It is no longer needed as it was only required (for Firefox) when
InputControlhad to be focused in order to update itself.How?
Removes the code and a unit test that was specific to it.
Testing Instructions
NumberControlcan be clicked to increment/decrement without causing the input to gain focus.InputControlstill behave as expected.Screen Recording
input-control-no-forced-focus.mp4