Post Comments: Fix invalid date format in placeholder #40929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisherranz
added
the
[Block] Comments (legacy)
luisherranz
added
Backport to WP 6.7 Beta/RC
|
Size Change: +2 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
luisherranz
added
the
Backport to WP 6.7 Beta/RC
cbravobernal
approved these changes
May 9, 2022
|
Thanks @luisherranz and @c4rl0sbr4v0! |
|
I've cherry-picked this to wp/6.0 branch to be included in WordPress 6.0 RC2 later today 57833ed |
adamziel
pushed a commit
that referenced
this pull request
May 10, 2022
adamziel
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix invalid date format in the Post Comments placeholder.
Why?
The date that is shown in the Editor doesn't exist because when am/pm is used, there is no 00 hour, as explained in #40916. Even though it is just a placeholder, we should use a valid date.
How?
Change 00:00 to 12:00.
Testing Instructions
<!-- wp:post-comments /-->.Screenshots or screencast