Comments block e2e test: Remove now-obsolete Post Comments Form block #40793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
michalczaplinski
deleted the
remove/obsolete-post-comments-form-from-comments-e2e-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove two lines that inserted Post Comments Form blocks as part of the Comments (The Block Formerly Known as Comments Query Loop) e2e test.
Why?
These were needed to enable the e2e test to post comments on the frontend. But as of #40256, the Post Comments Form block is part of the Comments block default template, which we're inserting separately anyway. This means that the e2e test can post comments by using that form (and there's no more need for the separate one).
How?
Say "What?" 😬
Testing Instructions
Verify that e2e tests are still green in CI, or run locally.
Screenshots or screencast
Here's the "Before", showing both the Post Comments Form that's now part of the Comments block, and the separate one that we were inserting below:
(Found while looking into an issue flagged here.)