Fix performance tests by adding backwards compatibility to welcome guide utility #39300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
talldan
force-pushed
the
try/fixing-performance-tests
branch
from
c6e3ac7 to
2454eeb
Compare
talldan
added
[Type] Bug
youknowriad
approved these changes
Mar 9, 2022
talldan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the performance tests.
Why?
The tests are currently failing in
trunk.They fail when comparing performance against an old version of the codebase, we can see in the logs the commit reference being used as the basis for the tests and that the site editor tests fail:
The commit referenced (debd225) is from January, which predates the preferences store being introduced to the site editor in #39158.
The stack trace has this (I've snipped the irrelevant bits):
Which shows that when running tests for this old branch, the test is trying to use the preferences store API (
getfunction) to turn off the welcome guide, but the preferences store won't exist at that commit reference.What confuses me is that I would've thought the old performance test would run using a corresponding older version of the test code and test utils. That doesn't seem to be the case though.
How?
I've added some backwards compatibility to the
disableSiteEditorWelcomeGuideutil.