[RN Mobile][Global Styles] Adds new Prop for Global Styles Settings #30544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis
added
[Status] In Progress
|
Size Change: -6 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
antonis
force-pushed
the
rnmobile/3163-GSS
branch
2 times, most recently
from
8a662f1 to
c3dde94
Compare
antonis
changed the title
This was referenced May 5, 2021
Merged
Merged
7 tasks
chipsnyder
reviewed
May 14, 2021
|
|
||
| private func properties(from editorSettings: GutenbergEditorSettings?) -> [String : Any] { | ||
| var settingsUpdates = [String : Any]() | ||
| settingsUpdates["isFSETheme"] = editorSettings?.isFSETheme ?? false |
There was a problem hiding this comment.
@antonis @geriux I pushed the iOS Changes in bf75be1. As part of that, I included isFSETheme which maps to __unstableEnableFullSiteEditingBlocks which may not be critical yet but I included it in case it helps identify if colors and gradients are blank because the theme wants the default values or if it's blank because we're using an FSE theme.
This was referenced May 14, 2021
…ents (#30684) * Mobile - Read global styles and set color palette and gradients * Parse all color variables * Fix gradients * Update global styles mocked data * Move color settings * Removed added spaces * Add tests * Update experimental features path and prepare for rawGlobalStylesBaseStyles * Remove mock data and update code to use latest API changes
# Conflicts: # packages/editor/src/components/provider/index.native.js
This reverts commit 32a2b3a.
* Mobile - Read global styles and set color palette and gradients * Mobile - Enable colors for blocks that support it * Parse all color variables * Mobile - Set background, title, text and link colors * Fix gradients * Add placeholder color * Update global styles mocked data * Move color settings * Removed added spaces * Add tests * Update experimental features path and prepare for rawGlobalStylesBaseStyles * Add missing provider * Get the right color attribute * Remove mock data * Mobile - Fix base global colors
chipsnyder
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
These changes look good to me. I agree with @geriux we can move this forward and merge as we work to figure out the best timing to enable the feature.
This was referenced Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: wordpress-mobile/gutenberg-mobile#3163
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3459WordPress-AndroidPR: wordpress-mobile/WordPress-Android#14597WordPress-FluxC-AndroidPR: wordpress-mobile/WordPress-FluxC-Android#1940WordPress-iOSPR: wordpress-mobile/WordPress-iOS#16411WordPressKit-iOSPR: wordpress-mobile/WordPressKit-iOS#394Description
Adds new Prop for Global Styles Settings
How has this been tested?
Follow the test instructions on:
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).