Fix label only mode parent selector. #28721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
5 tasks
|
Size Change: +42 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Should we have the margin gap still? Feels kind of weird without the gap. Or would it make more sense to push it to the end in this context? |
|
I'd like that gap, even if it'd make the toolbar even wider. The problem is that it's pretty tricky to make that gap happen, because the text label can have arbitrary width, which means we can't abs-position it, it has to push the rest of the toolbar. Because it's hard to address, I thought it good to get this out as a low-code hotfix, and then hopefully we can circle back. And circle back we should, becaus the whole toolbar can benefit substantially from a dedicated iteration: the MacOS finder handles text-only buttons decently:
|
|
Agreed — it might make sense to increase the block label font-size a bit to give it proper hierarchy, for example. |
mtias
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on feedback in #28598 (comment) where it was clear the text-label only mode regressed with the parent block selector. Sorry about that. So this is sort of a hotfix.
Icons:
Labels:
The little space between the selectors is non trivial to add, but happy to try in a followup. But just for the sake of the total width of the label-only toolbar, even saving those 10 pixels benefits this, so I decided this was a good first step.
Checklist: