Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add heading to the block inserter groups #22859 #22903

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Add heading to the block inserter groups #22859 #22903

merged 1 commit into from
Jun 5, 2020

Conversation

gaambo
Copy link
Contributor

@gaambo gaambo commented Jun 4, 2020 •
edited by youknowriad
Loading

closes #22859

Description

Changes the headings of block groups from spans to h2 to provide a semantic structuring.
Also changes the margin so styling is the same as with spans before and overwrites default h2 stylings.
Related to #22859

How has this been tested?

  • Open the block inserter - headings should look exactly as before the commit (same margin, font-size etc).
  • Should be tested with a screenreader?

Screenshots

grafik

Types of changes

Bug fix, css-class is the same as before and styling is the same.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ZebulanStanphill ZebulanStanphill added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Jun 4, 2020
@youknowriad youknowriad added Needs Accessibility Feedback Need input from accessibility Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Jun 4, 2020
youknowriad
youknowriad approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me.

I'd appreciate a quick a11y confirmation @enriquesanchez @afercia

@afercia
Copy link
Contributor

afercia commented Jun 5, 2020

LGTM to me, thanks @gaambo !

@youknowriad youknowriad merged commit 6622dd1 into WordPress:master Jun 5, 2020
@github-actions github-actions bot added this to the Gutenberg 8.3 milestone Jun 5, 2020
@gaambo gaambo deleted the block-inserter-headings branch June 5, 2020 11:51
@oandregal oandregal added the [Type] Enhancement A suggestion for improvement. label Jun 8, 2020
@oandregal oandregal changed the title Add semantic headings to block inserter groups #22859 Add heading to the block inserter groups #22859 Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees
No one assigned
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code Needs Accessibility Feedback Need input from accessibility [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 8.3
Development

Successfully merging this pull request may close these issues.

Regression: the new Block Inserter doesn't use headings to identify block sections any longer
5 participants
@gaambo @afercia @youknowriad @oandregal @ZebulanStanphill