Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heading to the block inserter tips (#22863) #22898

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Add heading to the block inserter tips (#22863) #22898

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5524834
Adds a heading to the block inserters tips (#22863)
Jun 4, 2020
0c20597
render visuallyhidden as h2 and adapt heading text
Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/block-editor/src/components/inserter/menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { includes } from 'lodash';
*/
import { useState } from '@wordpress/element';
import { LEFT, RIGHT, UP, DOWN, BACKSPACE, ENTER } from '@wordpress/keycodes';
import { TabPanel } from '@wordpress/components';
import { TabPanel, VisuallyHidden } from '@wordpress/components';
import { __ } from '@wordpress/i18n';
import { useSelect } from '@wordpress/data';

Expand Down Expand Up @@ -92,6 +92,11 @@ function InserterMenu( {
</div>
{ showInserterHelpPanel && (
<div className="block-editor-inserter__tips">
<VisuallyHidden>
<h2 className="block-editor-inserter__tips-title">
{ __( 'Tips for using the block editor:' ) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍 I think we should probably remove the ":" and we may want to reword that a little bit. I'll add a "copy review" label.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - should I wait for the copy review before updating the PR without the : or should I change it right now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's wait a bit and do a single update.

Copy link
Member

@ZebulanStanphill ZebulanStanphill Jun 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since only one tip is shown at a time, I think it should say "Tip for using the block editor".

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the copy, can we just say "Block editor tip!"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michelleweber Remember, this is screen-reader-only text. I think adding an exclamation point might make the screen reader say it with a different inflection, which may not be desirable. (Then again, I've never used a screen reader, so I have no idea.)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, gotcha. In that case, I say stick with "A tip for using the block editor:"

(With whatever final punctuation makes the most sense for a screen reader.)

</h2>
</VisuallyHidden>
<Tips />
</div>
) }
Expand Down