Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover: Set custom color when applying initial background image #22564
Cover: Set custom color when applying initial background image #22564
Changes from 8 commits
2dab13e
e07f370
78732b2
fa4d59e
5bdefaf
bad740d
df515ae
60c3578
a705c48
a6a63db
5cb1c44
c49e4b2
54799c5
59faa2a
0794f03
e5a7e3a
cc9e0c0
2b04cd8
a74392d
431c6ef
8a0bbfa
cf51693
c407669
d62e498
291012b
ad809ac
756656e
1f6ffc7
91a7aa6
cec9121
ea75467
cdbdab3
53a15a5
73d87f8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to avoid a network request and process the content of file when it's uploaded? In some cases like drag & drop or when uploading with the media placeholder (the one in Gutenberg) we already use data of the image to show the placeholder. /cc @ellatrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tapping into
getMedia
could be good.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to not touch this file 🙈 . I'm open to changing this implementation if it's a concern