Deprecate '@wordpress/nux' package #18981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Feature] NUX
noisysocks
requested review from
ajitbohra,
gziolo,
jorgefilipecosta,
nerrad,
ntwb,
talldan,
TimothyBJacobs and
youknowriad
as code owners
|
At some point, we will have to archive |
noisysocks
force-pushed
the
update/deprecate-nux
branch
2 times, most recently
from
b1fe7b3 to
8b2899a
Compare
noisysocks
force-pushed
the
update/deprecate-nux
branch
from
8b2899a to
7e75038
Compare
This was referenced Dec 19, 2019
mmtr
added a commit
to Automattic/wp-calypso
that referenced
this pull request
Dec 30, 2019
SPT is currently dispatching a `disableTips` action for disabling the welcome guide when the page layout selector is displayed, but `@wordpress/nux` will be deprecated and not imported by default in Gutenberg 7.2.0 (WordPress/gutenberg#18981). That means that `disableTips` will not be available and will break the editor: This PR handles that deprecation by hiding the welcome guide using `isFeatureActive( 'welcomeGuide' )`/`toggleFeature( 'welcomeGuide' )` (available since Gutenberg 7.1.0) and defers to `disableTips` only when the action is available (Gutenberg 7.0.0 and below).
|
Hi @noisysocks, does this change needs to be backported in WordPress core? |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does:
areTipsEnabledpreference in thecore/nuxstore withfeatures.welcomeGuidein thecore/edit-poststore.@wordpress/nux.@wordpress/nuxas a dependency from other packages in Gutenberg. (It is no longer needed as of Implement welcome guide modal #18041).How to test:
Clear your browser's persisted state by running
localStorage.clear()in DevToolsBuild and run a version of Gutenberg that does not have Implement welcome guide modal #18041 merged in:
Open the block editor
Dismiss tips
Close the document inspector
Build and run this branch:
Reload the block editor
The welcome guide should not appear and the sidebar should still be closed.