Improve absurd z-index values; put notices back under flyout menus #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: editor/assets/stylesheets/_z-index.scss
nylen
force-pushed
the
update/absurd-z-indices
branch
from
01f541f
to
a4b40d0
Compare
This PR fixes z-index issues with notices, but not with popovers. This is a bit more tricky and needs some design attention. We can change the popover z-index value to
|
|
A related change from WordPress Core: https://core.trac.wordpress.org/changeset/24753 |
Yes, it looks like this should be fixed at the layout level for that breakpoint. cc @jasmussen |
mtias
approved these changes
Jul 14, 2017
nylen
changed the title
|
Created an issue for the buggy popover behavior at #1901. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-roll of #1630.
Follow-up to #1437 and #1691.
When we have to add large
z-indexvalues, we should leave comments explaining why. We should also make sure we understand how the variousz-indexrules relate to each other, and ensure that the values we add are as large as necessary but no larger.