-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Block: vertically align items. #18399
Conversation
@mtias Will you be continuing working on this PR or would you like someone to take it over? Also is it "Blocking"? |
I know it's not an ideal solution but would it be an option to just give the appender button a 1px margin-top? That would nudge it down a little, make it look centered on the single line but wouldn't affect the layout beyond that. |
We need to be careful to not pixel-optimize towards any given font, as each font will have different needs here. Not doing anything is an option, even if I appreciate the intent of this ticket. |
I won't have time soon to finish it. Definitely not blocking, but I think it's worth trying to address as these details compound. |
It has tackled in #19681. Please feel free to re-open or create a new one if you consider that it's needed. |
This ensures items are properly aligned — depending on the font size the inserter can be misplaced.
Before:

After:

Might still need some work when selecting an item.