Fix incorrect nesting of buttons within a button #17342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9033.
The
DotTip
component renders buttons, so nesting it within another button was causing invalid DOM nesting. This PR makes theDotTip
and theButton
siblings and both children of a new parentdiv
element.DotTip
requires this parentdiv
element to position itself in the right place.Since #16315 (comment) proposes to remove
DotTip
s at some point, I've left a comment to ensure the wrapping div is removed when that work is carried out.Screenshots
How has this been tested?
Warning: validateDOMNesting(...): <button> cannot appear as a descendant of <button>.
message does not appear in the console.Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: