Address a11y feedback

WordPress · Jul 13, 2020 · ee899f9 · ee899f9
1 parent 85a2a0c
commit ee899f9
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 2 deletions.
diff --git a/packages/block-editor/src/components/block-types-list/index.js b/packages/block-editor/src/components/block-types-list/index.js
@@ -19,6 +19,7 @@ function BlockTypesList( {
 	onSelect,
 	onHover = () => {},
 	children,
+	label,
 } ) {
 	const composite = useCompositeState();
 	const normalizedItems = includeVariationsInInserterItems( items );
@@ -31,9 +32,10 @@ function BlockTypesList( {
 		/* eslint-disable jsx-a11y/no-redundant-roles */
 		<Composite
 			as="ul"
-			role="list"
+			role="listbox"
 			{ ...composite }
 			className="block-editor-block-types-list"
+			aria-label={ label }
 		>
 			{ normalizedItems.map( ( item ) => {
 				return (

diff --git a/packages/block-editor/src/components/inserter-list-item/index.js b/packages/block-editor/src/components/inserter-list-item/index.js
@@ -31,7 +31,7 @@ function InserterListItem( {
 		: {};
 
 	return (
-		<li className="block-editor-block-types-list__list-item">
+		<li className="block-editor-block-types-list__list-item" role="option">
 			<CompositeItem
 				as={ Button }
 				{ ...composite }

diff --git a/packages/block-editor/src/components/inserter/block-types-tab.js b/packages/block-editor/src/components/inserter/block-types-tab.js
@@ -132,6 +132,7 @@ export function BlockTypesTab( {
 						items={ filteredItems }
 						onSelect={ onSelectItem }
 						onHover={ onHover }
+						label={ __( 'Child Blocks' ) }
 					/>
 				</ChildBlocks>
 			) }
@@ -145,6 +146,7 @@ export function BlockTypesTab( {
 							items={ suggestedItems }
 							onSelect={ onSelectItem }
 							onHover={ onHover }
+							label={ _x( 'Most used', 'blocks' ) }
 						/>
 					</InserterPanel>
 				) }
@@ -165,6 +167,7 @@ export function BlockTypesTab( {
 								items={ categoryItems }
 								onSelect={ onSelectItem }
 								onHover={ onHover }
+								label={ category.title }
 							/>
 						</InserterPanel>
 					);
@@ -179,6 +182,7 @@ export function BlockTypesTab( {
 						items={ uncategorizedItems }
 						onSelect={ onSelectItem }
 						onHover={ onHover }
+						label={ __( 'Uncategorized' ) }
 					/>
 				</InserterPanel>
 			) }
@@ -200,6 +204,7 @@ export function BlockTypesTab( {
 								items={ collectionItems }
 								onSelect={ onSelectItem }
 								onHover={ onHover }
+								label={ collection.title }
 							/>
 						</InserterPanel>
 					);

diff --git a/packages/block-editor/src/components/inserter/quick-inserter.js b/packages/block-editor/src/components/inserter/quick-inserter.js
@@ -78,6 +78,7 @@ function QuickInserterList( {
 						items={ shownBlockTypes }
 						onSelect={ onSelectBlockType }
 						onHover={ onHover }
+						label={ __( 'Blocks' ) }
 					/>
 				</InserterPanel>
 			) }

diff --git a/packages/block-editor/src/components/inserter/reusable-blocks-tab.js b/packages/block-editor/src/components/inserter/reusable-blocks-tab.js
@@ -67,6 +67,11 @@ function ReusableBlocksList( {
 				items={ filteredItems }
 				onSelect={ onSelectItem }
 				onHover={ onHover }
+				label={
+					filterValue
+						? __( 'Search Results' )
+						: __( 'Reusable blocks' )
+				}
 			/>
 		</InserterPanel>
 	);