Components: Set a default for the ComboboxControl onFilterValueChange (…

…#28492) * Make the onFieldValueChange prop optional by setting a default. * Update the Storybook example. * Swap to using lodash's noop
WordPress · Feb 10, 2021 · 9a5fef7 · 9a5fef7
1 parent dd6c72e
commit 9a5fef7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 15 deletions.
diff --git a/packages/components/src/combobox-control/index.js b/packages/components/src/combobox-control/index.js
@@ -2,7 +2,7 @@
  * External dependencies
  */
 import classnames from 'classnames';
-import { deburr } from 'lodash';
+import { noop, deburr } from 'lodash';
 /**
  * WordPress dependencies
  */
@@ -46,7 +46,7 @@ function ComboboxControl( {
 	label,
 	options,
 	onChange,
-	onFilterValueChange,
+	onFilterValueChange = noop,
 	hideLabelFromVision,
 	help,
 	allowReset = true,

diff --git a/packages/components/src/combobox-control/stories/index.js b/packages/components/src/combobox-control/stories/index.js
@@ -259,14 +259,14 @@ export default {
 	component: ComboboxControl,
 };
 
-function ComboboxControlWithState() {
-	const mapCountryOption = ( country ) => ( {
-		value: country.code,
-		label: country.name,
-	} );
-	const [ filteredOptions, setFilteredOptions ] = useState(
-		countries.map( mapCountryOption )
-	);
+const mapCountryOption = ( country ) => ( {
+	value: country.code,
+	label: country.name,
+} );
+
+const countryOptions = countries.map( mapCountryOption );
+
+function CountryCodeComboboxControl() {
 	const [ value, setValue ] = useState( null );
 
 	return (
@@ -275,13 +275,10 @@ function ComboboxControlWithState() {
 				value={ value }
 				onChange={ setValue }
 				label="Select a country"
-				options={ filteredOptions }
-				onFilterValueChange={ () =>
-					setFilteredOptions( countries.map( mapCountryOption ) )
-				}
+				options={ countryOptions }
 			/>
 			<p>Value: { value }</p>
 		</>
 	);
 }
-export const _default = () => <ComboboxControlWithState />;
+export const _default = () => <CountryCodeComboboxControl />;