Allow passing a null anchor

WordPress · Sep 6, 2022 · 1e3184a · 1e3184a
1 parent 562e23c
commit 1e3184a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 18 deletions.
diff --git a/packages/edit-post/src/components/sidebar/post-schedule/index.js b/packages/edit-post/src/components/sidebar/post-schedule/index.js
@@ -13,7 +13,7 @@ import {
 export default function PostSchedule() {
 	// Use internal state instead of a ref to make sure that the component
 	// re-renders when the anchor's ref updates.
-	const [ popoverAnchor, setPopoverAnchor ] = useState();
+	const [ popoverAnchor, setPopoverAnchor ] = useState( null );
 
 	return (
 		<PostScheduleCheck>
@@ -23,10 +23,7 @@ export default function PostSchedule() {
 			>
 				<span>{ __( 'Publish' ) }</span>
 				<Dropdown
-					popoverProps={ {
-						// `anchor` can not be `null`
-						anchor: popoverAnchor ?? undefined,
-					} }
+					popoverProps={ { anchor: popoverAnchor } }
 					position="bottom left"
 					contentClassName="edit-post-post-schedule__dialog"
 					focusOnMount

diff --git a/packages/edit-post/src/components/sidebar/post-template/index.js b/packages/edit-post/src/components/sidebar/post-template/index.js
@@ -17,7 +17,7 @@ import { store as editPostStore } from '../../../store';
 export default function PostTemplate() {
 	// Use internal state instead of a ref to make sure that the component
 	// re-renders when then anchor's ref updates.
-	const [ popoverAnchor, setPopoverAnchor ] = useState();
+	const [ popoverAnchor, setPopoverAnchor ] = useState( null );
 
 	const isVisible = useSelect( ( select ) => {
 		const postTypeSlug = select( editorStore ).getCurrentPostType();
@@ -51,10 +51,7 @@ export default function PostTemplate() {
 		<PanelRow className="edit-post-post-template" ref={ setPopoverAnchor }>
 			<span>{ __( 'Template' ) }</span>
 			<Dropdown
-				popoverProps={ {
-					// `anchor` can not be `null`
-					anchor: popoverAnchor ?? undefined,
-				} }
+				popoverProps={ { anchor: popoverAnchor } }
 				position="bottom left"
 				className="edit-post-post-template__dropdown"
 				contentClassName="edit-post-post-template__dialog"

diff --git a/packages/edit-post/src/components/sidebar/post-url/index.js b/packages/edit-post/src/components/sidebar/post-url/index.js
@@ -13,17 +13,14 @@ import {
 export default function PostURL() {
 	// Use internal state instead of a ref to make sure that the component
 	// re-renders when then anchor's ref updates.
-	const [ popoverAnchor, setPopoverAnchor ] = useState();
+	const [ popoverAnchor, setPopoverAnchor ] = useState( null );
 
 	return (
 		<PostURLCheck>
 			<PanelRow className="edit-post-post-url" ref={ setPopoverAnchor }>
 				<span>{ __( 'URL' ) }</span>
 				<Dropdown
-					popoverProps={ {
-						// `anchor` can not be `null`
-						anchor: popoverAnchor ?? undefined,
-					} }
+					popoverProps={ { anchor: popoverAnchor } }
 					position="bottom left"
 					className="edit-post-post-url__dropdown"
 					contentClassName="edit-post-post-url__dialog"

diff --git a/packages/edit-post/src/components/sidebar/post-visibility/index.js b/packages/edit-post/src/components/sidebar/post-visibility/index.js
@@ -14,7 +14,7 @@ import { useState } from '@wordpress/element';
 export function PostVisibility() {
 	// Use internal state instead of a ref to make sure that the component
 	// re-renders when then anchor's ref updates.
-	const [ popoverAnchor, setPopoverAnchor ] = useState();
+	const [ popoverAnchor, setPopoverAnchor ] = useState( null );
 
 	return (
 		<PostVisibilityCheck
@@ -37,8 +37,7 @@ export function PostVisibility() {
 								// Anchor the popover to the middle of the
 								// entire row so that it doesn't move around
 								// when the label changes.
-								// `anchor` can not be `null`
-								anchor: popoverAnchor ?? undefined,
+								anchor: popoverAnchor,
 							} }
 							focusOnMount
 							renderToggle={ ( { isOpen, onToggle } ) => (