Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to set ip resolver type in request options #375

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ShivamYuvraj
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 11, 2019

Codecov Report

Merging #375 into master will decrease coverage by 0.09%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #375      +/-   ##
============================================
- Coverage     92.12%   92.02%   -0.10%     
- Complexity      761      763       +2     
============================================
  Files            21       21              
  Lines          1764     1767       +3     
============================================
+ Hits           1625     1626       +1     
- Misses          139      141       +2     
Impacted Files Coverage Δ Complexity Δ
library/Requests.php 75.59% <ø> (ø) 118.00 <0.00> (ø)
library/Requests/Transport/cURL.php 92.82% <33.33%> (-0.87%) 68.00 <0.00> (+2.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a0bbc...3a8caf8. Read the comment docs.

@jrfnl
Copy link
Member

jrfnl commented Dec 12, 2019

@ShivamYuvraj Thank you for contributing. Would it be possible to add some unit tests for this change ?

@ozh
Copy link
Collaborator

ozh commented Mar 15, 2020

Any idea on how to implement a unit test that would not add yet another dependency on an external host?

@jrfnl jrfnl changed the base branch from stable to develop June 18, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants