Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove needless memcpys in wooting_usb_send_buffer_v2 #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sainan
Copy link

@Sainan Sainan commented Oct 28, 2023

This is basically what I do in my own code and It Just Works™, even tho it looks a bit counterintuitive.

@simon-wh
Copy link
Member

Hmmm, it does look like it'll work fine, but it also looks like it's a bit trickier to maintain and for people to immediately understand.
Is the cost of the additional memcpy enough to make it worth it?

@Sainan
Copy link
Author

Sainan commented Jan 18, 2024

Well, the cost if 4 memcpys per packet to send. It's your decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants