Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Code Tabs #43

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Adding Code Tabs #43

merged 2 commits into from
Oct 10, 2022

Conversation

x-delfino
Copy link
Collaborator

@x-delfino x-delfino commented Sep 20, 2022

  • Patch for using Tabs for code snippets which provides a nice way to present using different tools etc.
    • Added code tabs to Azure Storage page
    • Added section to Contributing. Not sure if this is in the most appropriate place in this section
  • Renamed Azure_Storage_Accounts.md to azure_storage.md (it looks like the menu ordering is alphabetical based on the filename and is case sensitive which we should get cleaned up)

@chrisphilipov - can you QA what I've added to the Contributing page please?

@netlify
Copy link

netlify bot commented Sep 20, 2022

Deploy Preview for confident-wilson-c4de9b ready!

Name Link
🔨 Latest commit 12d1cba
🔍 Latest deploy log https://app.netlify.com/sites/confident-wilson-c4de9b/deploys/633b30831f5c130009e8ab75
😎 Deploy Preview https://deploy-preview-43--confident-wilson-c4de9b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NJonesUK
Copy link
Collaborator

NJonesUK commented Oct 3, 2022

Can we get the code tabs to wrap text, rather than horizontal scroll? Otherwise, LGTM

@x-delfino
Copy link
Collaborator Author

x-delfino commented Oct 5, 2022

@NJonesUK so it looks like code blocks get an option to wrap text when they extend past the viewable length, however, this works per codeblock and will always default to non-wrapping (this is hardcoded). There's some discussions over in Docusaurus around how to improve this facebook/docusaurus#7875, but basically it's currently:

  • Code blocks are not linewrapped by default
  • Users can click the 'wrap' button on individual code blocks to wrap the text
  • This wrap option does not affect other code blocks

Bear in mind that the above is consistent across all code blocks, not specific to using these tabs. I'll keep an eye on that issue to see if anything changes but don't think there's much that we can do for now

@chrisphilipov chrisphilipov merged commit 2d9e81e into WithSecureLabs:main Oct 10, 2022
@x-delfino x-delfino deleted the code_tabs branch February 23, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants