Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deformable conv to repo #190

Merged
merged 4 commits into from
Oct 5, 2022
Merged

Conversation

Kracozebr
Copy link

Tried my best to add deformable conv to yolact edge. Unfortunately I have not have enough gpu to train on coco or over dataset to test metrics.

@haotian-liu
Copy link
Collaborator

Thank you so much for the contribution! I will take a look at this soon -- we need to check on the compatibility with the new torch2trt dynamic plugin with the existing configurations, as well as its affect on the speed. Thanks!

@haotian-liu haotian-liu self-assigned this Apr 22, 2022
@Kracozebr
Copy link
Author

Thank you so much for the contribution! I will take a look at this soon -- we need to check on the compatibility with the new torch2trt dynamic plugin with the existing configurations, as well as its affect on the speed. Thanks!

Thanks, wait for your response! =)

@haotian-liu
Copy link
Collaborator

Thank you so much for your effort and sincerely apologize for the late follow-up as I have been working on a lot of other things :(

Your contribution has been merged :)

@haotian-liu haotian-liu merged commit 3f423ed into WisconsinAIVision:master Oct 5, 2022
@haotian-liu
Copy link
Collaborator

Hi, as reported in #225, I noticed that the rock dataset was set as the default, causing the visualizations to break. I have temporarily reverted this change as a fix. I'll double check and add back the deformable conv feature to the repo later.
If you have time, it'd be very much appreciated if you could help make this change too.
Thank you again for your contributions.

@Kracozebr
Copy link
Author

Hi, I turned out that I forgot to delete my dataset from config file, I made one more commit with fixes of config.py. What is the best way to add commit to pr?

@haotian-liu
Copy link
Collaborator

haotian-liu commented Dec 12, 2022

Maybe you can create a new pull request by first reverting this reversion commit (05db000)? And then make the modification. Please let me know if this makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants