Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public profile pages and basic contribution management #96

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

nitinseshadri
Copy link
Contributor

@nitinseshadri nitinseshadri commented Jul 27, 2020

This PR adds the following:

  • Public profile pages, viewable by going to /user/profile/<username> or /user/profile/<uuid>, or, to view their own profile, users can go to /user/profile or click the link in the user menu.
  • Admin interface for viewing and rejecting contributions, including a reason why it was rejected.
  • Users can view, but not edit, their own contributions, if any, by going to /library/my/contributions (same route as before) or clicking the link in the user menu.
  • Ability to accept new contributions is controlled by a config switch, allowContributions (boolean).
  • The route /library/contribute is now operable, but largely incomplete. For now, I recommend setting the setting mentioned above to false, and advising admins to not click "Create Release" in the admin interface contribution page.

@NattyNarwhal
Copy link
Contributor

Code wise this looks good so far, and I'll give it a try locally, but some thoughts:

  • As mentioned on IRC, I need to flesh out the design for the contributions system to make it simpler than the previous system in terms of maintainability. Avoid things like crazy FTP setups. This looks fine, I'll just provide some design documentation to make the original vision clear, since it's been stuck in my head for years now.
  • User profile code looks fine, but I'm not sure if public user profiles are appropriate for the CMS itself, since generally users don't care about other users, except in a forum context. This could change if we ever move forums and such internally into the CMS though.

@nitinseshadri
Copy link
Contributor Author

nitinseshadri commented Aug 3, 2020

I'm not sure if public user profiles are appropriate for the CMS itself, since generally users don't care about other users, except in a forum context.

Yeah, the idea is that these will become the profile pages for the forum at some point. Vanilla allows you to set custom profile URLs, but it would require some changes to the SSO code as detailed here: https://open.vanillaforums.com/discussion/28209/change-the-url-of-user-profile
EDIT: Look at the very last post in the thread for full instructions.

@nitinseshadri
Copy link
Contributor Author

@NattyNarwhal Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants