modify validation of needed option due to fact that kerberos authenti… #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cator doesnt need user and password provided it only needs kerberos ticket
pcai
reviewed
Jun 7, 2024
| @@ -68,8 +68,8 @@ def validate_required_fields | |||
| if self[:client_cert] | |||
| raise 'path to client key is required' unless self[:client_key] | |||
| else | |||
| raise 'user is a required option' unless self[:user] | |||
| raise 'password is a required option' unless self[:password] | |||
| raise 'user is a required option' unless self[:transport] == :kerberos | |||
There was a problem hiding this comment.
with this change: if user and password but not kerberos is provided, this will raise, won't it? that seems incorrect.
|
hi - is this PR still needed? If so, please address comment above and add tests for your new case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cator doesnt need user and password provided it only needs kerberos ticket