Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans for merging the icc color profile support recently added to sway? #348

Open
kockahonza opened this issue Aug 22, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@kockahonza
Copy link

Pretty much the title. I am talking about this pull request that has added the color_profile option for the output command. I ask as it is pretty major feature for me given how oversaturated colors are without it on my screen.

@WillPower3309
Copy link
Owner

Happy to backport this change to swayfx early, not on my todo list, but open to PRs

@WillPower3309
Copy link
Owner

otherwise we can get it for free next sway release

@kockahonza
Copy link
Author

Oh I see, so swayfx always fully catches up to any changes in sway with their releases (with major changes being backported sooner)? I was wondering about how this was managed.

When it comes to adding this earlier it's not that essential for me. I have gone back to sway for now but I am perfectly happy to wait for a while and I don't really have the time at the moment to work on this and I expect the same applies to others. I'm of course happy to test though :) and I am looking forward to switching when it gets there.

@AleMax
Copy link

AleMax commented Sep 14, 2024

Hi, sorry if I am wrong here, but considering this needs the vulkan renderer of wlr_renderer, are we sure that we can just get this for free with the next sway release?

@WillPower3309
Copy link
Owner

Hi, sorry if I am wrong here, but considering this needs the vulkan renderer of wlr_renderer, are we sure that we can just get this for free with the next sway release?

You could be right, I haven't dove into the implementation yet. If it does require Vulkan than yes we won't get it yet :/

@markstos
Copy link
Contributor

markstos commented Nov 2, 2024

Seems like this will be resolved by #360, rebasing off Sway 1.10.

@WillPower3309
Copy link
Owner

Seems like this will be resolved by #360, rebasing off Sway 1.10.

Yup, but if it needs the Vulkan renderer this wouldn't be the case. Still need to dive into the implementation to determine that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants