Merge pull request #175 from WillAbides/deadcode

check for dead code

.github/workflows/ci.yml

@@ -53,6 +53,7 @@ jobs:
           key: ${{ runner.os }}-go-lint-${{ hashFiles('**/go.sum', 'bindown.yml', 'script/*') }}
           restore-keys: ${{ runner.os }}-go-lint
       - run: script/lint
+      - run: script/deadcode
   generate:
     runs-on: ubuntu-22.04
     steps:

cmd/bindown/cli.go

@@ -113,14 +113,6 @@ type fileReader interface {
 	Fd() uintptr
 }
 
-type SimpleFileReader struct {
-	io.Reader
-}
-
-func (s SimpleFileReader) Fd() uintptr {
-	return 0
-}
-
 type runContext struct {
 	parent  context.Context
 	stdin   fileReader

cmd/bindown/testutil_test.go

@@ -20,6 +20,14 @@ import (
 	"gopkg.in/yaml.v3"
 )
 
+type simpleFileReader struct {
+	io.Reader
+}
+
+func (s simpleFileReader) Fd() uintptr {
+	return 0
+}
+
 type cmdRunner struct {
 	t          testing.TB
 	configFile string
@@ -60,7 +68,7 @@ func (c *cmdRunner) run(commandLine ...string) *runCmdResult {
 		ctx,
 		commandLine,
 		&runOpts{
-			stdin:   SimpleFileReader{c.stdin},
+			stdin:   simpleFileReader{c.stdin},
 			stdout:  SimpleFileWriter{&result.stdOut},
 			stderr:  &result.stdErr,
 			cmdName: "cmd",

internal/bindown/jsonschema.go

@@ -3,7 +3,6 @@ package bindown
 import (
 	"context"
 	_ "embed"
-	"encoding/json"
 	"fmt"
 
 	"github.com/santhosh-tekuri/jsonschema/v5"
@@ -30,12 +29,3 @@ func validateConfig(ctx context.Context, cfg []byte) error {
 	}
 	return nil
 }
-
-func yaml2json(y []byte) ([]byte, error) {
-	var data any
-	err := yaml.Unmarshal(y, &data)
-	if err != nil {
-		return nil, err
-	}
-	return json.Marshal(data)
-}

internal/bindown/jsonschema_test.go

@@ -2,11 +2,13 @@ package bindown
 
 import (
 	"context"
+	"encoding/json"
 	"os"
 	"path/filepath"
 	"testing"
 
 	"github.com/stretchr/testify/require"
+	"gopkg.in/yaml.v3"
 )
 
 func TestValidateConfig(t *testing.T) {
@@ -72,3 +74,12 @@ url_checksums:
 		require.Error(t, err)
 	})
 }
+
+func yaml2json(y []byte) ([]byte, error) {
+	var data any
+	err := yaml.Unmarshal(y, &data)
+	if err != nil {
+		return nil, err
+	}
+	return json.Marshal(data)
+}

script/deadcode

@@ -0,0 +1,27 @@
+#!/bin/sh
+
+set -e
+
+REPO_DIR="$(CDPATH="" cd -- "$(dirname -- "$0")/.." && pwd -P)"
+
+DEADCODE_REVISION="aac7fb67aecb"
+
+GOBIN="$REPO_DIR"/bin go install golang.org/x/tools/internal/cmd/deadcode@"$DEADCODE_REVISION"
+
+RESULT="$(
+  "$REPO_DIR"/bin/deadcode -line ./... |
+    grep -v "internal/expecttest." |
+    grep -v "internal/testutil." || true
+)"
+
+TEST_RESULT="$(
+  "$REPO_DIR"/bin/deadcode -line -test ./... |
+    grep -v "internal/builddep.adhocRelease" || true
+)"
+
+if [ -n "$RESULT" ] || [ -n "$TEST_RESULT" ]; then
+  echo "deadcode found unused code:"
+  echo "$RESULT"
+  echo "$TEST_RESULT"
+  exit 1
+fi

script/fmt

@@ -2,7 +2,7 @@
 
 set -e
 
-CDPATH="" cd -- "$(dirname -- "$(dirname -- "$0")")"
+CDPATH="" cd -- "$(dirname -- "$0")/.."
 
 script/bindown -q install gofumpt shfmt