Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helpful--docstring: skip advice only if advised #264

Closed
wants to merge 1 commit into from
Closed

helpful--docstring: skip advice only if advised #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions helpful.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2529,10 +2529,9 @@ escapes that are used by `substitute-command-keys'."
(setq docstring (documentation sym t))
(-when-let (docstring-with-usage (help-split-fundoc docstring sym))
(setq docstring (cdr docstring-with-usage))
(when docstring
(when (and docstring (helpful--advised-p sym))
;; Advice mutates the docstring, see
;; `advice--make-docstring'. Undo that.
;; TODO: Only do this if the function is advised.
(setq docstring (helpful--skip-advice docstring)))))
(setq docstring
(documentation-property sym 'variable-documentation t)))
Expand Down