Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update react base path #775

Merged
merged 2 commits into from
Sep 20, 2024
Merged

update react base path #775

merged 2 commits into from
Sep 20, 2024

Conversation

erinz2020
Copy link
Contributor

@erinz2020 erinz2020 commented Sep 20, 2024

update hardcoded path "/react" to variable process.env.PUBLIC_URL

PR fixes issue #506

@erinz2020 erinz2020 self-assigned this Sep 20, 2024
Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erinz2020 erinz2020 merged commit 3f90878 into dev10.4 Sep 20, 2024
1 check passed
@erinz2020 erinz2020 deleted the update_react_base_path branch September 20, 2024 19:03
@erinz2020 erinz2020 linked an issue Sep 23, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React app often hardcodes public URL
2 participants