Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLATFORM-10117: Migrate UsingData to MW 1.43 #9

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

wladekb
Copy link
Contributor

@wladekb wladekb commented Feb 13, 2025

No description provided.

@wladekb wladekb force-pushed the PLATFORM-10117-migrate-usingdata branch 8 times, most recently from 32e3560 to 9383c5c Compare February 14, 2025 08:29
@wladekb wladekb force-pushed the PLATFORM-10117-migrate-usingdata branch from 9383c5c to 8c05ad2 Compare February 14, 2025 08:35
Copy link

@albsko albsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Wladek, I consider you a great engineer, but unfortunately I won't pass your PRs thru code review this time because of the issues below:

Detected some globals 🥶
global $wgNonincludableNamespaces; and global $wgHooks;

Please, use those imports within UsingDataHooks.php and UsingDataPPFrameDOM.php if needed.

use MediaWiki\Parser\Parser;
use MediaWiki\Title\Title;

EDIT: sorry about the globals - they are fine, I forgot to bootstrap locally 🙇

@wladekb
Copy link
Contributor Author

wladekb commented Feb 14, 2025

globals were just removed, did I miss anything?
good catch with use Title

@ezachwieja ezachwieja merged commit 378c4ad into master Feb 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants